[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2069-2070 +// this point. +// TODO: Shouldn't we track control dependencies of every bug location, +// rather than only tracked expressions? +if (LVState->getAnalysi

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rG967c06b3e95b: [analyzer] Reimplement trackExpressionValue as ExpressionHandler (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D103616?vs=351121&id=351378#toc Repository:

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko updated this revision to Diff 351121. vsavchenko added a comment. Remove parts from the next commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 Files: clang/lib/StaticAnalyzer/Core/BugRep

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko added a comment. Oh boy! I screwed up with interactive rebases 🥲 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 ___ cfe-commits mailing list cfe-com

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko updated this revision to Diff 351102. vsavchenko added a comment. Rebase and change `KnownSVal` to `SVal` in `trackStoredValue` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 Files: clang/in

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko updated this revision to Diff 351099. vsavchenko added a comment. Rebase and change how we call track for values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 Files: clang/lib/StaticAnalyze

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Everything's perfect, can't complain! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko updated this revision to Diff 349652. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index: c

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko updated this revision to Diff 349549. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index: c

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.