cebowleratibm requested changes to this revision.
cebowleratibm added a comment.
This revision now requires changes to proceed.
I think it makes sense to split the __STDC macro changes and __TOS_AIX__ into
different patches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
Jake-Egan updated this revision to Diff 349855.
Jake-Egan added a comment.
Use LangStandard::isC11() and one C99 test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103587/new/
https://reviews.llvm.org/D103587
Files:
clang/lib/Basic/Targets/OSTa
Jake-Egan updated this revision to Diff 349854.
Jake-Egan marked 3 inline comments as done.
Jake-Egan added a comment.
Use LangStandard::isC11() and one C99 test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103587/new/
https://reviews.llvm.org/D1
cebowleratibm added inline comments.
Comment at: clang/lib/Basic/Targets/OSTargets.h:680
+
+if (Opts.LangStd == LangStandard::lang_c11 ||
+Opts.LangStd == LangStandard::lang_gnu11 ||
I think LangStandard::isC11() does what you want. You wouldn't want
Jake-Egan updated this revision to Diff 349638.
Jake-Egan added a comment.
Set macros for C11 and higher. Add negative test for pre C11.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103587/new/
https://reviews.llvm.org/D103587
Files:
clang/lib/
cebowleratibm requested changes to this revision.
cebowleratibm added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Basic/Targets/OSTargets.h:680
+
+if (Opts.LangStd == LangStandard::lang_c11 ||
+Opts.LangStd == LangStandard::la
Jake-Egan updated this revision to Diff 349564.
Jake-Egan marked an inline comment as done.
Jake-Egan added a comment.
Fix formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103587/new/
https://reviews.llvm.org/D103587
Files:
clang/lib/Bas
Jake-Egan updated this revision to Diff 349557.
Jake-Egan edited the summary of this revision.
Jake-Egan added a comment.
Removed __THW_PPC__ and moved tests to init-ppc.c
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103587/new/
https://reviews.ll
cebowleratibm requested changes to this revision.
cebowleratibm added a comment.
This revision now requires changes to proceed.
Please rework the test update into init-ppc.c
Comment at: clang/lib/Basic/Targets/PPC.cpp:95
Builder.defineMacro("_ARCH_PPC");
+ Builder.defineMac