[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

smd added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->size--; fmayer wrote: > fmayer wrote: > > fmayer wrote: > > > vitalybuka wrote: > > > > mayb

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->size--; fmayer wrote: > fmayer wrote: > > vitalybuka wrote: > > > maybe we should pop eve

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->size--; fmayer wrote: > vitalybuka wrote: > > maybe we should pop everything up to "pc" t

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added a comment. In D103562#3702962 , @smd wrote: > Hi folks, > > I've been working on support hwasan for risc-v and I believe I've found an > issue with the existing lit tests this commit causes. > Tests stack-{oob,uar,uas}.c check for correct ba

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

smd added a comment. Hi folks, I've been working on support hwasan for risc-v and I believe I've found an issue with the existing lit tests this commit causes. Tests stack-{oob,uar,uas}.c check for correct backtrace being printed. From the code and comments the idea is to not to print any hwasa

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

vitalybuka added a subscriber: smd. vitalybuka added inline comments. Herald added a subscriber: Enna1. Herald added a project: All. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->siz

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4e478b8: [NFC][compiler-rt][hwasan] Refactor hwasan functions (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

leonardchan updated this revision to Diff 349689. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103562/new/ https://reviews.llvm.org/D103562 Files: compiler-rt/lib/hwasan/hwasan.cpp compiler-rt/lib/h

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:192 + +void HandleTagMismatch(AccessInfo ai, uptr pc, uptr frame, + void *uc, uptr *registers_

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

leonardchan updated this revision to Diff 349404. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103562/new/ https://reviews.llvm.org/D103562 Files: compiler-rt/lib/hwasan/hwasan.cpp compiler-rt/li

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek, eugenis, vitalybuka. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. This moves the implementations f