craig.topper added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:836
+ clang::CharUnits Align =
+ CGM.getNaturalTypeAlignment(getContext().getSizeType());
+ llvm::Value *V;
I don't think this alignment is correct. A vin
This revision was automatically updated to reflect the committed changes.
Closed by commit rG593bf9b4ded3: [Clang][RISCV] Implement vlseg and vlsegff.
(authored by HsiangKai).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103527/new/
https://reviews
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103527/new/
https://reviews.llvm.org/D103527
___
HsiangKai added a comment.
Ping. Is it possible to land these Zvlsseg patches before LLVM 13 branch
created?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103527/new/
https://reviews.llvm.org/D103527
__
HsiangKai updated this revision to Diff 354117.
HsiangKai added a comment.
Split vlseg and vlseg_ff tests in two different files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103527/new/
https://reviews.llvm.org/D103527
Files:
clang/include/cla
rogfer01 added a comment.
Do you think you can split `vlseg` and `vlseg_ff` tests in two different files?
So we (potentially) reduce the test latency by half in multicore systems.
Other than this, LGTM.
We're a bit split in https://github.com/riscv/rvv-intrinsic-doc/issues/95
However there are
HsiangKai updated this revision to Diff 349754.
HsiangKai added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103527/new/
https://reviews.llvm.org/D103527
Files:
clang/include/clang/Basic/IdentifierTable.h
clang/in
craig.topper added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:807
+ // intrinsic: (ptr, vl)
+ SmallVector Operands = {Ops[NF], Ops[NF + 1]};
+ llvm::Function *F = CGM.getIntrinsic(ID, IntrinsicTypes);
This can be a `llvm
HsiangKai created this revision.
HsiangKai added reviewers: frasercrmck, craig.topper, rogfer01.
Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques,
apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,
brucehoult, MartinMosbeck, edward-jones, zzhe
