lkail abandoned this revision.
lkail added a comment.
Herald added a project: All.
Most are covered by https://reviews.llvm.org/D122377 already.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103501/new/
https://reviews.llvm.org/D103501
___
hubert.reinterpretcast added inline comments.
Comment at: clang/test/CodeGen/ppc64-quadword-atomics.c:10
+
+// CHECK-NOT: call void @__atomic_exchange
+// CHECK: +quadword-atomics
lkail wrote:
> hubert.reinterpretcast wrote:
> > Can you add a link to something th
lkail added inline comments.
Comment at: clang/test/CodeGen/ppc64-quadword-atomics.c:10
+
+// CHECK-NOT: call void @__atomic_exchange
+// CHECK: +quadword-atomics
hubert.reinterpretcast wrote:
> Can you add a link to something that demonstrates that the implement
hubert.reinterpretcast added inline comments.
Comment at: clang/test/CodeGen/ppc64-quadword-atomics.c:10
+
+// CHECK-NOT: call void @__atomic_exchange
+// CHECK: +quadword-atomics
Can you add a link to something that demonstrates that the implementation of
`__at
lkail added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.cpp:336
.Default(false);
+ Features["quadword-atomics"] = llvm::StringSwitch(CPU)
+ .Case("pwr10", true)
qiucf wrote:
> What about `
lkail updated this revision to Diff 353268.
lkail added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103501/new/
https://reviews.llvm.org/D103501
Files:
clang/lib/Basic/Targets/PPC.cpp
clang/lib/Basic/Targets/PPC.
qiucf added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.cpp:336
.Default(false);
+ Features["quadword-atomics"] = llvm::StringSwitch(CPU)
+ .Case("pwr10", true)
What about `ppc64`?
Also,
lkail created this revision.
lkail added reviewers: nemanjai, jsji, xingxue, hubert.reinterpretcast,
cebowleratibm, PowerPC.
Herald added subscribers: jfb, kbarton.
Herald added a reviewer: jfb.
lkail requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-