[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review! I've commit in ca68f3bc48e48f839142de1461e95d87ae48e9df . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Ah! Thats what I missed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103485/new/ https://reviews.llvm.org/D103485 __

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

aaron.ballman added a comment. In D103485#2791940 , @erichkeane wrote: > The patch looks fine to me, though I don't particularly get the test changes > that move a diagnostic by 1 line? The `global-vs-module.cpp` test had a line removed from it for the

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

erichkeane added a comment. The patch looks fine to me, though I don't particularly get the test changes that move a diagnostic by 1 line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103485/new/ https://reviews.llvm.org/D103485

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. The following was found by a customer and is accepted by the other primary C++ compilers, but fails to compile in Clang