This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG721476e6b211: [clang] Fix a crash during code completion
(authored by adamcz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
we discussed offline but i forgot to stamp this one. it would be nice to have a
test case, but fix is relatively safe and getting a repro turned out to be hard
(since it depends on a dense
adamcz added a reviewer: kadircet.
adamcz added a comment.
This is https://github.com/clangd/clangd/issues/771
Sending for review mostly to see if you have any comments on this approach.
Trying to reproduce this without , or something like this didn't
work for me so far, I must be holding it w
adamcz created this revision.
adamcz requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
During code completion, lookupInDeclContext() calls
CodeCompletionDeclConsumer::FoundDecl(),which can mutate StoredDeclsMap,
over which lookupInDeclContext
