This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdc10bf1a4ed0: [clangd][Protocol] Drop optional from
WorkspaceEdit::changes (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SI
kadircet updated this revision to Diff 349371.
kadircet marked an inline comment as done.
kadircet added a comment.
Get rid of the special case around empty changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103449/new/
https://reviews.llvm.org
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
changes is in fact optional, indicated by the `?` in `changes?: { [uri:
DocumentUri]: TextEdit[]; };`.
But the spec requires *some* field to be set, and this is the only one we
support,
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This is causing weird code patt
