This revision was not accepted when it landed; it landed in state "Changes
Planned".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd12000ca55d1: [clangd] Bump recommended gRPC version (1.33.2
->
kadircet accepted this revision.
kadircet added a comment.
looks like the https://lab.llvm.org/buildbot/#/builders/131 is green after the
version bump. thanks for taking care of this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103393/new/
https
kbobyrev planned changes to this revision.
kbobyrev added a comment.
Makes sense, thanks! Putting this on hold.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103393/new/
https://reviews.llvm.org/D103393
kadircet added a comment.
I think we should wait for build bot update on this one too. Otherwise we might
miss some breakages.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103393/new/
https://reviews.llvm.org/D103393
kbobyrev added a comment.
I don't really know if we should do this before the buildbot update so I just
wanted to know your opinion @kadircet.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103393/new/
https://reviews.llvm.org/D103393
kbobyrev created this revision.
kbobyrev added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
kbobyrev requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Context: https://github.com/clan
