This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3198364e6e49: [RISCV][Clang] Add support for Zmmul extension
(authored by ksyx).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ksyx updated this revision to Diff 445461.
ksyx marked an inline comment as done.
ksyx added a comment.
Update zmmul version & rebase
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103313/new/
https://reviews.llvm.org/D103313
Files:
clang/lib/Basic/Targets/RISCV.cpp
clang/test/Drive
asb added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:80
+{"zmmul", RISCVExtensionVersion{0, 1}},
+
craig.topper wrote:
> If it is ratified, is the version really 0.1?
It looks like it should be 1.0 now
https://github.com/riscv/riscv-isa
craig.topper accepted this revision.
craig.topper added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:80
+{"zmmul", RISCVExtensionVersion{0, 1}},
+
If it is ratified, is the version really 0.
ksyx updated this revision to Diff 445332.
ksyx added a comment.
Rebase and update use of M extension existence check to include Zmmul whenever
needed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103313/new/
https://reviews.llvm.org/D103313
Files:
clang/lib/Basic/Targets/RISCV.cpp
craig.topper requested changes to this revision.
craig.topper added a comment.
This revision now requires changes to proceed.
Need to update RISCVTargetLowering::decomposeMulByConstant.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103313/new/
https://reviews.llvm.org/D103313
_
ksyx added a comment.
ping :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103313/new/
https://reviews.llvm.org/D103313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ksyx updated this revision to Diff 440075.
ksyx marked an inline comment as done.
ksyx added a comment.
Make Zmmul extension independent instead of implied by M extension for backward
ELF attribute compatibility.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103313/new/
https://reviews
craig.topper added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCV.td:25
+ "'M' (Integer Multiplication and Division)",
+ [FeatureStdExtZmmul]>;
def HasStdExtM : Predicate<"Subtarget->hasStdExtM()">,
This will
ksyx updated this revision to Diff 440017.
ksyx retitled this revision from "[RISCV][Clang] Implement support for
zmmul-experimental" to "[RISCV][Clang] Add support for Zmmul extension".
ksyx edited the summary of this revision.
ksyx added a comment.
Herald added subscribers: sunshaoce, StephenFan
10 matches
Mail list logo