[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

melver added a comment. In D103159#2784926 , @aaron.ballman wrote: > In D103159#2784845 , @melver wrote: > >> Ping. > > FWIW, the usual practice is to ping after no activity on the review for about > a week. > >

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4fbc66cd6d90: [Clang] Enable __has_feature(coverage_sanitizer) (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D103159#2784845 , @melver wrote: > Ping. FWIW, the usual practice is to ping after no activity on the review for about a week. That

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

melver marked 3 inline comments as done. melver added a comment. Ping. To reviewers: Do note the `feature` vs. `extension` discussion. Summary: We think to be consistent with other sanitizers and avoid confusion, we must make this a `feature`, too. Thanks. Repository: rG LLVM Github Monorep

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

ojeda added inline comments. Comment at: clang/include/clang/Basic/Features.def:52 LangOpts.Sanitize.hasOneOf(SanitizerKind::Undefined)) +FEATURE(coverage_sanitizer, LangOpts.SanitizeCoverage) FEATURE(assume_nonnull, true) melver wrote: > ojeda wrote: >

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

melver added inline comments. Comment at: clang/include/clang/Basic/Features.def:52 LangOpts.Sanitize.hasOneOf(SanitizerKind::Undefined)) +FEATURE(coverage_sanitizer, LangOpts.SanitizeCoverage) FEATURE(assume_nonnull, true) ojeda wrote: > melver wrote:

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

ojeda added inline comments. Comment at: clang/include/clang/Basic/Features.def:52 LangOpts.Sanitize.hasOneOf(SanitizerKind::Undefined)) +FEATURE(coverage_sanitizer, LangOpts.SanitizeCoverage) FEATURE(assume_nonnull, true) melver wrote: > aaron.ballman

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

melver updated this revision to Diff 348021. melver marked an inline comment as done. melver added a comment. s/Since/Because/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103159/new/ https://reviews.llvm.org/D103159 Files: clang/docs/Sanitizer

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

melver added inline comments. Comment at: clang/include/clang/Basic/Features.def:52 LangOpts.Sanitize.hasOneOf(SanitizerKind::Undefined)) +FEATURE(coverage_sanitizer, LangOpts.SanitizeCoverage) FEATURE(assume_nonnull, true) aaron.ballman wrote: > I thin

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

aaron.ballman added a reviewer: rsmith. aaron.ballman added inline comments. Comment at: clang/docs/SanitizerCoverage.rst:319 It is possible to disable coverage instrumentation for select functions via the -function attribute ``__attribute__((no_sanitize("coverage")))``. +functi

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

melver updated this revision to Diff 347936. melver added a comment. Documentation wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103159/new/ https://reviews.llvm.org/D103159 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

melver created this revision. melver added reviewers: aaron.ballman, vitalybuka, morehouse, nickdesaulniers. Herald added a subscriber: dexonsmith. melver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Like other sanitizers, enable __has_f