This revision was automatically updated to reflect the committed changes.
Closed by commit rG333987b04589: [OpenCL] Add DWARF address spaces mapping for
SPIR (authored by jzzheng22, committed by stuart).
Changed prior to commit:
https://reviews.llvm.org/D103097?vs=348910&id=349910#toc
Reposito
stuart added inline comments.
Comment at: clang/test/CodeGenOpenCL/spir-debug-info-pointer-address-space.cl:22
+// CHECK-DAG: distinct !DIGlobalVariable(name: "FileVar5", scope: !{{[0-9]+}},
file: !{{[0-9]+}}, line: {{[0-9]+}}, type: ![[DWARF_ADDRESS_SPACE_GLOBAL]],
isLocal: fa
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103097/new/
https://reviews.llvm.org/D103097
___
cfe-commits mailing lis
jzzheng22 updated this revision to Diff 348910.
jzzheng22 added a comment.
Simplified test following review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103097/new/
https://reviews.llvm.org/D103097
Files:
clang/lib/Basic/Targets/SPIR.h
clang/test/CodeGenOpenCL/spir-debug
Anastasia added inline comments.
Comment at: clang/test/CodeGenOpenCL/spir-debug-info-pointer-address-space.cl:22
+// CHECK-DAG: distinct !DIGlobalVariable(name: "FileVar5", scope: !{{[0-9]+}},
file: !{{[0-9]+}}, line: {{[0-9]+}}, type: ![[DWARF_ADDRESS_SPACE_GLOBAL]],
isLocal:
jzzheng22 updated this revision to Diff 347708.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103097/new/
https://reviews.llvm.org/D103097
Files:
clang/lib/Basic/Targets/SPIR.h
clang/test/CodeGenOpenCL/spir-debug-info-pointer-address-space.cl
Index: clang/test/CodeGenOpenCL/spir-deb
jzzheng22 created this revision.
jzzheng22 added reviewers: cfe-commits, Anastasia.
jzzheng22 requested review of this revision.
Herald added a project: clang.
Extend debug info handling by adding DWARF address space mapping for SPIR, with
corresponding test case.
Repository:
rG LLVM Github M
