[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4cf807aeaf: [clang] [MinGW] Don't mark emutls variables as DSO local (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D102970?vs=347216&id=348379#toc Repository: rG LLVM Gi

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102970/new/ https://reviews.llvm.org/D102970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

mstorsjo added a comment. @rnk Does this seem ok to you too? Comment at: clang/lib/CodeGen/CodeGenModule.cpp:992 +// (and this actually happens in the public interface of libstdc++), so +// such variables can't be marked as DSO local. if (GV->isDeclarationForLinker

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

mati865 accepted this revision. mati865 added a comment. This revision is now accepted and ready to land. Wow, I haven't expected that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102970/new/ https://reviews.llvm.org/D102970

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

mstorsjo created this revision. mstorsjo added reviewers: rnk, mati865. mstorsjo requested review of this revision. Herald added a project: clang. These actually can be automatically imported from another DLL. (This works properly as long as the actual implementation of emutls is linked dynamicall