This revision was automatically updated to reflect the committed changes.
Closed by commit rGf59cd8a4a606: [clang] [MinGW] Fix gcc version
detection/picking (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D102873?vs=346850&id=348464#toc
Repository:
rG LLVM Github Mo
mati865 added a comment.
Ah, so that explains why everyone sends LGTM text.
I'll try to remember it next time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102873/new/
https://reviews.llvm.org/D102873
_
mstorsjo added a comment.
Also @mati865 FYI, phabricator has this odd behaviour, that if you press
"accept" but don't write a textual message, the notification mail only gets
sent to the person receivers but not to the mailing list - so readers of the
list will only see the original messages an
MaskRay accepted this revision.
MaskRay added a comment.
LGTM.
Comment at: clang/test/Driver/mingw-sysroot.cpp:21
// RUN: env "PATH=%T/testroot-gcc/bin:%PATH%" %clang -target
x86_64-w64-mingw32 -rtlib=platform -stdlib=libstdc++ --sysroot="" -c -### %s
2>&1 | FileCheck -check
mstorsjo added reviewers: MaskRay, mati865.
mstorsjo added a comment.
Adding some more reviewers, this is a trivial bug fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102873/new/
https://reviews.llvm.org/D102873
___
mstorsjo updated this revision to Diff 346850.
mstorsjo added a comment.
Update another affected testcase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102873/new/
https://reviews.llvm.org/D102873
Files:
clang/lib/Driver/ToolChains/MinGW.cpp
mstorsjo created this revision.
mstorsjo added a reviewer: rnk.
mstorsjo requested review of this revision.
Herald added a project: clang.
Actually compare each version to the version of the last chosen one.
There's no guarantee that the added test case does showcase the
previous issue (it depend
