[PATCH] D102814: [AIX] Print printable byte list as quoted string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedf4d69d3888: [AIX] Print printable byte list as quoted string (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346907. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp llvm/include/llvm/M

[PATCH] D102814: [AIX] Print printable byte list as quoted string

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments; thanks! Comment at: llvm/include/llvm/MC/MCAsmInfo.h:268-270 + /// This directive allows emission of an ascii strin

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1008 + for (const unsigned char C : Data) { +if (!isPrint(C)) + return false; jsji wrote: > This still need some slight change to deal with the ending 0 so that we can > handle .stri

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346830. jsji added a comment. Update .string handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp llvm/include

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1008 + for (const unsigned char C : Data) { +if (!isPrint(C)) + return false; This still need some slight change to deal with the ending 0 so that we can handle .string. Repository

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346794. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp llvm/include/llvm/M

[PATCH] D102814: [AIX] Print printable byte list as quoted string

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1007-1008 +static inline bool isPrintableString(StringRef Data) { + const auto BeginPtr = Data.begin(), EndPtr = Data.end(); + for (const unsigned char C : make_range(BeginPtr, EndPtr)) { +

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji created this revision. jsji added reviewers: PowerPC, hubert.reinterpretcast, DiggerLin, xingxue, shchenz. Herald added subscribers: hiraditya, nemanjai. jsji requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. .byte sup