[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb42564ec4b: [CUDA][HIP] Fix device variables used by host (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. I've verified that Tensorflow still builds with this patch and that the patch does fix the regressions we've seen. If you could land this patch soon, that would be appreciated. CHANGES SINCE

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl updated this revision to Diff 346831. yaxunl marked 3 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102801/new/ https://reviews.llvm.org/D102801 Files: clang/include/clang/Sema/Sema.h clang/lib/Code

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12066 + enum CUDAVariableTarget { +CVT_Device, /// Device only tra wrote: > Wasn't there another kind, where the variable is emitted on the

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

tra added a comment. In D102801#2771664 , @yaxunl wrote: > In the updated patch I have a simpler solution which is easier to explain to > the users. Basically we classify variables by how they are emitted: device > side only, host side only, both sides

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D102801#2769619 , @tra wrote: > Tentative LGTM as we need it to fix the regression soon. > > Summoning @rsmith for the 'big picture' opinion. > While the patch may fix this particular re

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D102801#2769936 , @tra wrote: > This patch does not appear to fix the second regression introduced by the > D102237 . > > Trying to compile the followin

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl updated this revision to Diff 346796. yaxunl retitled this revision from "[CUDA][HIP] Fix implicit constant variable" to "[CUDA][HIP] Fix device variables used by host". yaxunl edited the summary of this revision. yaxunl added a comment. Fix the other regression CHANGES SINCE LAST ACTION