[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">, HelpTe

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rG033138ea452f: [IR] make stack-protector-guard-* flags into module attrs (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/n

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 _

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">, HelpText<"In

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347130. nickdesaulniers added a comment. - moved module attr mismatch test to llvm/test/Linker/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files: clang

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: llvm/test/LTO/AArch64/stack-protector-guard-module-attrs.ll:2-5 +; RUN: not llvm-link %t/a.ll %t/b.ll 2>&1 | FileCheck --check-prefix=CHECK-KIND %s +; RUN: not llvm-link %t/c.ll %t/d.ll 2>&1 | FileCheck --check-prefix=CHECK-REG

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">, HelpTe

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: llvm/test/LTO/AArch64/stack-protector-guard-module-attrs.ll:2-5 +; RUN: not llvm-link %t/a.ll %t/b.ll 2>&1 | FileCheck --check-prefix=CHECK-KIND %s +; RUN: not llvm-link %t/c.ll %t/d.ll 2>&1 | FileCheck --check-prefix=CHECK-REG

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347124. nickdesaulniers added a comment. Herald added a subscriber: steven_wu. - add llvm/tests/LTO/AArch64/ and test case for module attr mismatch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/n

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added inline comments. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"none"}]>; + MarshallingInfoString>; def mfentry : Flag<["-"], "mfentry">, HelpText<"In

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Will work on explicit LTO tests. Comment at: clang/include/clang/Driver/Options.td:3429 HelpText<"Use the given reg for addressing the stack-protector guard">, - MarshallingInfoString, [{"non

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added a comment. In D102742#2774639 , @nickdesaulniers wrote: > In D102742#2774562 , @tejohnson > wrote: > >> In D102742#2774185 , >> @nickdesaulniers wrote:

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347113. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - doxygen comments, test that module flags aren't emitted without flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added a comment. In D102742#2774562 , @tejohnson wrote: > In D102742#2774185 , > @nickdesaulniers wrote: > >> - upgrade module merge strategy to Error > > Probably want a test using llvm-link or l

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added a comment. In D102742#2774185 , @nickdesaulniers wrote: > - upgrade module merge strategy to Error Probably want a test using llvm-link or llvm-lto to check this behavior (that alike flags are getting propagated as expected and that con

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added a comment. In D102742#2773954 , @tejohnson wrote: > In D102742#2767569 , > @nickdesaulniers wrote: > >> Obviously needs work/cleanup, changes to x86, and tests, but posting for >> early fee

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 347068. nickdesaulniers added a comment. - upgrade module merge strategy to Error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files: clang/include/clang

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

tejohnson added a comment. In D102742#2767569 , @nickdesaulniers wrote: > Obviously needs work/cleanup, changes to x86, and tests, but posting for > early feedback about module level attributes vs function level attributes, or > possibly something else

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 346800. nickdesaulniers added a comment. - fix lints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 346585. nickdesaulniers added a comment. - remove spurious comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files: clang/include/clang/Driver/Options

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 346584. nickdesaulniers added a comment. Herald added a subscriber: dang. - add cc1 test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files: clang/includ

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: llvm/include/llvm/IR/Module.h:898 + // enum class StackProtectorGuards { None, TLS, Global, SysReg }; + StringRef getStackProtectorGuard() const; TODO: delete this comment Repository: rG LLVM Github Monor

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:776-783 + if (getCodeGenOpts().StackProtectorGuard != "") +getModule().setStackProtectorGuard(getCodeGenOpts().StackProtectorGuard); + if

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 346573. nickdesaulniers added a comment. Herald added a subscriber: pengfei. - remove TargetOption members, update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.or

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Obviously needs work/cleanup, changes to x86, and tests, but posting for early feedback about module level attributes vs function level attributes, or possibly something else. I tested this quickly with thin LTO

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, pcc, xiangzhangllvm. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-co