[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bc644aeca8f: Revert "[AIX] Avoid structor alias; die before bad alias codegen" (authored by Jake-Egan, committed by stevewan). Repository: rG LLV

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jsji added a comment. In D102724#2769756 , @jasonliu wrote: > Good idea, fyi, this is the patch: https://reviews.llvm.org/D83252 Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://r

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jasonliu added a comment. Good idea, fyi, this is the patch: https://reviews.llvm.org/D83252 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724 ___ cfe-commits mai

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jsji added a comment. > because AIX now has an alias implementation. Can we please include the patches or commits that implement the alias? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724 ___

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724 __

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan updated this revision to Diff 346560. Jake-Egan added a comment. Added the changes jasonliu asked for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724 Files: clang/lib/Driver/ToolChains/Clang.

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan added a comment. In D102724#2768663 , @stevewan wrote: > Might be a dumb question, but I see this is a revert to rGb116ded > , do we > also want to revert the changes added t

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

stevewan added a comment. Might be a dumb question, but I see this is a revert to rGb116ded , do we also want to revert the changes added to `llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp`? Comment at: clang/li

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jasonliu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4964 if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && - !RawTriple.isAMDGPU() && !RawTriple.isOSAIX()) + !RawTriple.isAMDGPU()) CmdArgs.push_back("-mconstructor-aliases"); --

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan created this revision. Jake-Egan added reviewers: cebowleratibm, jasonliu, sfertile, daltenty, DiggerLin, hubert.reinterpretcast. Herald added subscribers: jeroen.dobbelaere, nemanjai. Jake-Egan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribe