This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG85255a04e572: [C++][Sema] Ignore top-level qualifiers in
casts (authored by olestrohm).
Changed prior to commit:
https://reviews.llvm.org/D102689?
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
I think the diagnostic wording can be improved separately if it's considered
important as it seems this issue already existed.
I suggest adding `[Sema]` tag in your final
olestrohm added inline comments.
Comment at: clang/test/SemaCXX/warn-reinterpret-base-class.cpp:301
- // expected-warning@+2 {{'reinterpret_cast' to class 'L' (aka 'const F
*volatile') from its base at non-zero offset 'E *' behaves differently from
'static_cast'}}
+ // expe
Anastasia added inline comments.
Comment at: clang/test/SemaCXX/warn-reinterpret-base-class.cpp:301
- // expected-warning@+2 {{'reinterpret_cast' to class 'L' (aka 'const F
*volatile') from its base at non-zero offset 'E *' behaves differently from
'static_cast'}}
+ // expe
olestrohm updated this revision to Diff 350560.
olestrohm retitled this revision from "[C++4OpenCL] Allow address space
conversion in reinterpret_cast" to "[C++] Ignore top-level qualifiers in casts".
olestrohm edited the summary of this revision.
olestrohm added a comment.
I've added a check in
