[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

2023-07-27 Thread Sylvain Audi via Phabricator via cfe-commits
saudi abandoned this revision. saudi added a comment. Herald added a project: All. In D102633#2786288 , @aganea wrote: > @dexonsmith Yes, using the Clang Tooling C++ API seems like a good option, > however some logic could/would be needed from > `clang/

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

2021-05-27 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. @dexonsmith Yes, using the Clang Tooling API seems like a good option, however some logic could/would be needed from `clang/tools/clang-scan-deps/ClangScanDeps.cpp`. Using clang-scan-deps as-a-DLL seemed like the best option on the short term, since we're using its `main

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

2021-05-21 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a subscriber: jansvoboda11. dexonsmith added a comment. In D102633#2773578 , @aganea wrote: > In D102633#2769762 , @arphaman > wrote: > >> It might be good for @aganea to take a look as well. > >

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

2021-05-21 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a subscriber: mehdi_amini. aganea added a comment. In D102633#2769762 , @arphaman wrote: > It might be good for @aganea to take a look as well. Thanks! I actually work with @saudi, I already took a look at the patch before uploading. Howeve

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

2021-05-19 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a reviewer: aganea. arphaman added a comment. It might be good for @aganea to take a look as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102633/new/ https://reviews.llvm.org/D102633 __

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

2021-05-17 Thread Sylvain Audi via Phabricator via cfe-commits
saudi created this revision. saudi added reviewers: arphaman, dexonsmith, Bigcheese. saudi added projects: clang, LLVM. saudi requested review of this revision. Herald added a subscriber: cfe-commits. Switching back to `std::thread` to simplify the logic, as `ThreadPool` adds a layer of task mana