[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. So I will hide it from "Ready to Review" list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy added a comment. In D102592#2769811 , @eugenis wrote: > I think it is too hit-and-miss to add even under a flag. It's just not the > right approach - but I also don't know what the right approach would be. > > Perhaps adding a small left redzone fo

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

eugenis added a comment. I think it is too hit-and-miss to add even under a flag. It's just not the right approach - but I also don't know what the right approach would be. Perhaps adding a small left redzone for all globals and reducing the right redzone to keep the total size under control? T

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy added a comment. In D102592#2764357 , @eugenis wrote: > You are adding a new global to every translation unit. > > - Private linkage would not allow them to be merged, this can have > significant binary size and RAM overhead. Do you suggest linkon

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy added a comment. In D102592#2764085 , @vitalybuka wrote: > Would you mind to add compiler-rt/test/asan which triggers this one? Yes, I will. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

eugenis added a comment. You are adding a new global to every translation unit. - Private linkage would not allow them to be merged, this can have significant binary size and RAM overhead. - There is no guarantee that any of these globals will end up to the left of any sanitized globals. With -

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

vitalybuka added a comment. Would you mind to add compiler-rt/test/asan which triggers this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 ___ cfe-commits

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345786. condy added a comment. Fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeGen/asan-gl

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345784. condy added a comment. Fix all tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeGen/asa

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345777. condy added a comment. Fix some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeGen/as

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345767. condy added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Fil