[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

2021-05-17 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added a comment. I think you can add a NFC in the title. Comment at: clang/lib/Sema/TreeTransform.h:3947-3949 NestedNameSpecifierLoc NNS, QualType ObjectType,

[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

2021-05-17 Thread zhouyizhou via Phabricator via cfe-commits
zhouyizhou added a comment. I do some "grep" in clang/lib directory: llvm-project/clang/lib#find . -name "*.*"|xargs grep -n -B 2 "break;"|grep -A 2 "}" my patch also seems to match the coding style of other parts of clang. Thanks again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

2021-05-16 Thread zhouyizhou via Phabricator via cfe-commits
zhouyizhou updated this revision to Diff 345710. zhouyizhou added a comment. I use git diff -U9 instead CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102577/new/ https://reviews.llvm.org/D102577 Files: clang/lib/Sema/TreeTransform.h Index: clang/lib/Sema/TreeTransform.h ===

[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

2021-05-16 Thread zhouyizhou via Phabricator via cfe-commits
zhouyizhou created this revision. zhouyizhou added reviewers: sepavloff, craig.topper, rsmith, klimek, doug.gregor. Herald added a subscriber: pengfei. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi,