[PATCH] D102558: [Utils] Check for generated functions inline if possible

2021-05-19 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert planned changes to this revision. jdoerfert added a comment. This doesn't work properly yet :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102558/new/ https://reviews.llvm.org/D102558 ___ cfe

[PATCH] D102558: [Utils] Check for generated functions inline if possible

2021-05-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected:100 + } +} ggeorgakoudis wrote: > The checks for the outlined function are missing? Good catch. It turns out functions that showed up

[PATCH] D102558: [Utils] Check for generated functions inline if possible

2021-05-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 346030. jdoerfert marked 4 inline comments as done. jdoerfert added a comment. Skip duplicates in the line2spell_and_mangled_list as that causes functions to be missed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D102558: [Utils] Check for generated functions inline if possible

2021-05-17 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected:100 + } +} The checks for the outlined function are missing? Comment at: clang/test/utils/update_cc_test_chec

[PATCH] D102558: [Utils] Check for generated functions inline if possible

2021-05-15 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: greened, arichardson, ggeorgakoudis. Herald added a subscriber: bollu. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added projects: clang, LLVM. With D83004