This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rG18cb17ce4cd5: [HIP] Fix spack detection (authored by yaxunl).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D102556?vs=345643&i
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/test/Driver/rocm-detect.hip:115
+
+// SPACK-MISS-SILENT-NOT: SPACK package hip-4.0.0 not found at
+// SPACK-MISS-SILENT-NOT: SPACK package rocm-device-libs-4.0.0 not found at
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM with a test nit.
Comment at: clang/test/Driver/rocm-detect.hip:115
+
+// SPACK-MISS-SILENT-NOT: SPACK package hip-4.0.0 not found at
+// SPACK-MISS-SILENT-NOT: SPACK package r
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added subscribers: kerbowa, nhaehnle, jvesely.
yaxunl requested review of this revision.
Missing or duplicate spack package should not cause error, since
users may only installed llvm/clang package, or users may installed
duplicate
