[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans added a comment. In D102517#2789593 , @AbbasSabra wrote: > In D102517#2789450 , @goncharov > wrote: > >> Sorry, had to revert it as this fails under sanitizer : >> https://lab.llvm.org/buildbot/#/builders/

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG116179c2ee52: Re-commit [clang] Add support for the "abstract" con

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra added a comment. In D102517#2789450 , @goncharov wrote: > Sorry, had to revert it as this fails under sanitizer : > https://lab.llvm.org/buildbot/#/builders/5/builds/8150 Thanks! I missed adding "Ident_abstract" in the Parser initialize func

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra updated this revision to Diff 348806. AbbasSabra added a comment. Updating D102517 : [clang]Fix use-of-uninitialized-value detected by the sanitizer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/n

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

goncharov added a comment. Sorry, had to revert it as this fails under sanitizer : https://lab.llvm.org/buildbot/#/builders/5/builds/8150 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 _

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans added a comment. Pushed as http://github.com/llvm/llvm-project/commit/818338add77411f5e9713247ea66142f332ef350 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 ___

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG818338add774: [clang] Add support for the "abstract" contextual keyword of MSVC (authored by AbbasSabra, committed by hans). Repository: rG LLVM

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra added a comment. Thanks for the review! Can you take care of merging the patch? I don't have access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 ___

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 __

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra updated this revision to Diff 347955. AbbasSabra added a comment. Updating D102517 : [clang] Apply code review: while loop instead of for loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ h

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans added a comment. Apologies for the slow reply, it was a long weekend here. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:3314 if (getLangOpts().CPlusPlus && Tok.is(tok::identifier)) { -VirtSpecifiers::Specifier Specifier = isCXX11VirtSpecifier(Tok); -assert((Spec

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra added a comment. > Does MS use this in any library headers or such I didn't check if they do. But if any codebase does use "abstract" and they are trying to use clang-cl they would face a parsing error. My use case was running static analysis on code that uses this feature. Such an e

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra updated this revision to Diff 347018. AbbasSabra marked 3 inline comments as done. AbbasSabra added a comment. Updating D102517 : [clang]Apply code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans added a comment. Looking good overall, just a few nits. Out of curiosity, where would one run into this? Does MS use this in any library headers or such? Comment at: clang/lib/Parse/ParseDeclCXX.cpp:3314 if (getLangOpts().CPlusPlus && Tok.is(tok::identifier)) { -V

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

rnk added a comment. @hans, can you review this? I am trying to offload clang reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 ___ cfe-commits mailing l

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra created this revision. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://docs.microsoft.com/en-us/cpp/extensions/abstract-cpp-component-extensions?view=msvc-160 Repository: rG LLVM Github Monorepo https://re