[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa27a17f88386: [clang][AST] Add support for BindingDecl to ASTImporter. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

martong accepted this revision. martong added a comment. In D102492#2854811 , @balazske wrote: > Not using `auto` declarations. Still looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10249

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske updated this revision to Diff 356110. balazske marked an inline comment as done. balazske added a comment. Not using `auto` declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492 Files:

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske updated this revision to Diff 352372. balazske added a comment. Using `addDeclToContexts`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492 Files: clang/lib/AST/ASTImporter.cpp clang/unittests

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

martong added a comment. I like it, though I've found a nit. Comment at: clang/lib/AST/ASTImporter.cpp:2301 + ToD->setLexicalDeclContext(LexicalDC); + DC->addDeclInternal(ToD); + ToD->setBinding(ToType, ToBinding); Should we use rather `addDeclToContexts` ?

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske added a comment. This change in itself is not enough to support `BindingDecl`. The tests pass but the resulting AST is not correct because `DecompositionDecl` is not imported yet. Still no visible problem happens, the `DecompositionDecl` is just visited and imported as a `VarDecl`. The

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske updated this revision to Diff 346169. balazske added a comment. Improved the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/AST

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:873 + MatchVerifier Verifier; + testImport("int a[2] = {1, 2};" + "auto [declToImport, x] = a;", Can we add a larger variety of tests? Given how simple the `BindingDec

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske created this revision. Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-com