[PATCH] D102488: [clang][deps] Prune unused header search paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a1f50b84ae8: [clang][deps] Prune unused header search paths (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D102488?vs=378285&id=378953#toc Repository: rG LLVM Github M

[PATCH] D102488: [clang][deps] Prune unused header search paths

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 __

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 378285. jansvoboda11 added a comment. Rebase, switch from `std::vector` to `llvm::BitVector`, load the bit vector eagerly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.or

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. After speaking with @dexonsmith, the laziness is probably not necessary when dealing with a short bit vector. I'll also explore using `llvm::BitVector` instead of `std::vector`. Repository: rG LLVM Github Monorepo

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:374 + /// (potentially modified) context hash. + std::string constructPCMPath(const ModuleDeps &MD) const { +const std::string &ImplicitPCMPath = MD.ImplicitModulePCMPath;

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 marked an inline comment as done. jansvoboda11 added a comment. This is now ready for review. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:4 +"directory": "DIR", +"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 347042. jansvoboda11 added a comment. Split out extra patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Files: clang/include/clang/Serialization/ASTBitCode

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 346418. jansvoboda11 added a comment. Fix test on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Files: clang/include/clang/Lex/HeaderSearch.h clang

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 345922. jansvoboda11 added a comment. Make PCM parsing lazier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Files: clang/include/clang/Lex/HeaderSearch.h c

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. In D102488#2760406 , @dexonsmith wrote: > I think it'd be useful to have direct tests for "detecting used search > paths". That might be a nice thing to separate out and test i

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 345861. jansvoboda11 added a comment. Use, serialize and deserialize `llvm::BitVector` instead of `std::set`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Fil

[PATCH] D102488: [clang][deps] Prune unused header search paths

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. The code looks mostly good; some inline comments. I think it'd be useful to have direct tests for "detecting used search paths". That might be a nice thing to separate out an

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 345412. jansvoboda11 added a comment. Undo changes to `modules-full.cpp` test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Files: clang/include/clang/Lex/He

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To reduce the number of explicit builds of a single module, we can try to squash multiple