This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdbc641deb988: [sanitizer] Reduce redzone size for small size
global objects (authored by condy, committed by MaskRay).
Repository:
rG LLVM Github
MaskRay updated this revision to Diff 346614.
MaskRay added a comment.
Herald added a subscriber: steven_wu.
fix test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102469/new/
https://reviews.llvm.org/D102469
Files:
clang/test/CodeGen/asan-globa
condy marked 3 inline comments as done.
condy added inline comments.
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556
+ uint64_t RZ = 0;
+ if (SizeInBytes < MinRZ / 2) {
+// Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is
---
condy updated this revision to Diff 346612.
condy added a comment.
Apply optimization when SizeInBytes <= MinRZ/2
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102469/new/
https://reviews.llvm.org/D102469
Files:
clang/test/CodeGen/asan-globals-a
vitalybuka added a comment.
Do you need help with landing thin?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102469/new/
https://reviews.llvm.org/D102469
___
cfe-commits mailing list
cfe-commits@lists.l
vitalybuka added inline comments.
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556
+ uint64_t RZ = 0;
+ if (SizeInBytes < MinRZ / 2) {
+// Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is
MaskRay wrote:
> I wo
MaskRay accepted this revision.
MaskRay added inline comments.
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556
+ uint64_t RZ = 0;
+ if (SizeInBytes < MinRZ / 2) {
+// Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is
-
condy marked an inline comment as done.
condy added inline comments.
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556-2559
+ // Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is at
+ // least 32 bytes, optimize when SizeInBytes is
condy updated this revision to Diff 346055.
condy added a comment.
Update as suggected
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102469/new/
https://reviews.llvm.org/D102469
Files:
clang/test/CodeGen/asan-globals-alias.cpp
clang/test/CodeG
vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556-2559
+ // Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is at
+
eugenis added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102469/new/
https://reviews.llvm.org/D102469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
condy updated this revision to Diff 345386.
condy added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fix clang/codegen tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102469/new/
https://reviews.llvm.org/D10
12 matches
Mail list logo