This revision was automatically updated to reflect the committed changes.
Closed by commit rG50511df32edf: [AArch64] Lower bitreverse in ISel (authored
by Rin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102397/new/
https://reviews.llvm.org/D1023
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM
Comment at: llvm/test/CodeGen/AArch64/neon_rbit.ll:9
+
+define <8 x i8> @rbit_8x8(<8 x i8> %A) nounwind {
+; CHECK-LABEL: rbit_8x8:
v8i8 and v
Rin updated this revision to Diff 345465.
Rin added a comment.
Add AutoUpgrade test and move bitreverse lowering
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102397/new/
https://reviews.llvm.org/D102397
Files:
clang/lib/CodeGen/CGBuiltin.cpp
dmgreen added inline comments.
Comment at: llvm/lib/IR/AutoUpgrade.cpp:556
}
+if (Name.startswith("aarch64.neon.rbit")) {
+ NewFn = Intrinsic::getDeclaration(F->getParent(), Intrinsic::bitreverse,
Do we have a test for the autoupgrade, to show that
Rin updated this revision to Diff 345411.
Rin added a comment.
Remove unnecessary comment and add more bitreverse tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102397/new/
https://reviews.llvm.org/D102397
Files:
clang/lib/CodeGen/CGBuiltin
dmgreen added a comment.
Sounds good.
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:4134
-defm RBIT : SIMDTwoVectorB<1, 0b01, 0b00101, "rbit", int_aarch64_neon_rbit>;
+//defm RBIT : SIMDTwoVectorB<1, 0b01, 0b00101, "rbit",
int_aarch64_neon_rbit>;
+defm RBIT :
Rin created this revision.
Herald added subscribers: dexonsmith, danielkiss, hiraditya, kristof.beyls.
Rin requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D10
