[PATCH] D102240: [analyzer][solver] Prevent use of a null state

2021-05-13 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Thx for the fix! In D102240#2757223 , @steakhal wrote: > In D102240#2756967 , @vsavchenko > wrote: > >> I couldn't transform `c == b` into a condition, so it crashes. > > Well, that's intere

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

2021-05-13 Thread Valeriy Savchenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG45212dec01b9: [analyzer][solver] Prevent use of a null state (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102240/new/ https://rev

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

2021-05-13 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D102240#2756967 , @vsavchenko wrote: > I couldn't transform `c == b` into a condition, so it crashes. Well, that's interesting. It might worth

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

2021-05-13 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. In D102240#2750976 , @steakhal wrote: > Dam, we will be always haunted by these. Yep, it was one place where we didn't expect a null state, but after one of the later patches, it became possible. 🤞it's the final one. > Looks

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

2021-05-13 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 345145. vsavchenko added a comment. Modify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102240/new/ https://reviews.llvm.org/D102240 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

2021-05-11 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Dam, we will be always haunted by these. Looks good btw. The test looks somewhat artificial - like a raw `creduce` result. Do you think It worth the effort to make it look like it was written by a human? I also somewhy prefer function parameters to globals for this speci

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

2021-05-11 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, martong, steakhal. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. vsavchenko requested review of this revision. Herald added a pr