[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa6e87cc5a21: [TableGen] [Clang] Clean up arm_mve.td file. (authored by Paul-C-Anagnostopoulos). Changed prior to commit: https://reviews.llvm.org

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added a comment. Sorry, I removed it but didn't update this review. All set now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

dmgreen accepted this revision. dmgreen added a comment. Sorry. I think we were waiting for the foldl comment to be removed. If you remove that, this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 __

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM provided the output file stays the same. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 _

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added a comment. Could I get an LGTM on this? I have removed the spurious comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:1532 // // So this foldl expression implements what you'd write in Python as // [srctype for srctype in T.All if srctype != desttype] simon_tatham wrote: > If

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

simon_tatham added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:1532 // // So this foldl expression implements what you'd write in Python as // [srctype for srctype in T.All if srctype != desttype] If you've removed my unreadable `fo

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos updated this revision to Diff 344810. Paul-C-Anagnostopoulos added a comment. One must amend the commit when one makes changes to the files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 Files: clang/include/clang/Ba

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos updated this revision to Diff 344809. Paul-C-Anagnostopoulos added a comment. The arm_*.inc files do not change with this revision. I removed the commented-out code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 Files

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:579 + defvar halfconst = !ne(half, "b"); + defvar halfconst = !if(!eq(half, "b"), 0, 1); craig.topper wrote: > Did you intend to leave the old lines commented o

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

craig.topper added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:579 + defvar halfconst = !ne(half, "b"); + defvar halfconst = !if(!eq(half, "b"), 0, 1); Did you intend to leave the old lines commented out? Repository: rG LLVM Gith

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

simon_tatham added a comment. For example, that's how I tested the refactoring in D72690 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 ___

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

simon_tatham added a comment. For this kind of pure refactoring on a `.td` file, my usual approach to testing it is to run the file through Tablegen without any output option (i.e. just in the default `-print-records` mode), before and after the change. In this case, I'd think, you ought to be

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

dmgreen added a reviewer: simon_tatham. dmgreen added a comment. Testing the inc files sounds good to me. There are also tests in places like clang/test/CodeGen/arm-mve-intrinsics that will test this, which seem to all be passing? Anything that does `#include ` Repository: rG LLVM Github Mon

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: lattner, jansvoboda11, craig.topper, dblaikie. Herald added subscribers: dmgreen, kristof.beyls. Paul-C-Anagnostopoulos requested review of this revision. Herald added a project: clang. Herald added a subscriber: