[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

This revision was automatically updated to reflect the committed changes. Closed by commit rG833e9b2ea7a7: [BPF] add support for 32 bit registers in inline asm (authored by alessandrod, committed by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

yonghong-song added a comment. Sure. I will merge the patch for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102118/new/ https://reviews.llvm.org/D102118 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

alessandrod added a comment. In D102118#2761476 , @yonghong-song wrote: > LGTM except one minor issue. Please do address the nit before merging. Thanks! Done, thanks for the review! I don't have commit access so someone will have to merge this for me :

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

alessandrod updated this revision to Diff 345680. alessandrod added a comment. Remove unused global from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102118/new/ https://reviews.llvm.org/D102118 Files: clang/lib/Basic/Targets/BPF.cpp cla

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

yonghong-song accepted this revision. yonghong-song added a comment. This revision is now accepted and ready to land. LGTM except one minor issue. Please do address the nit before merging. Thanks! Comment at: clang/test/CodeGen/bpf-inline-asm.c:5 + +long var; +

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

alessandrod updated this revision to Diff 345599. alessandrod added a comment. Enable "w" constraint when -mcpu=v3 and fix whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102118/new/ https://reviews.llvm.org/D102118 Files: clang/lib/Ba

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

yonghong-song added a comment. Generally looks good. One suggestion and a few nits. Thanks! Comment at: clang/lib/Basic/Targets/BPF.cpp:54 +if (Feature == "+alu32") { + HasAlu32 = true; +} -mcpu=v3 also enables alu32. See below llvm code ``` void B

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

alessandrod created this revision. Herald added a subscriber: hiraditya. alessandrod requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Add "w" constraint type which allows selecting 32 bit registers. 32 bit registers were a