This revision was automatically updated to reflect the committed changes.
Closed by commit rG10c779d2065f: [AMDGPU][OpenMP] Emit textual IR for
-emit-llvm -S (authored by pdhaliwal).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102065/new/
https://
pdhaliwal added a comment.
Tested on gfx906. The libomptarget tests are working as expected.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102065/new/
https://reviews.llvm.org/D102065
___
cfe-commits mai
pdhaliwal updated this revision to Diff 344763.
pdhaliwal added a comment.
Fixed the if-else logic
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102065/new/
https://reviews.llvm.org/D102065
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/te
pdhaliwal added a comment.
This is not working as expected. And has resulted in broken libomptarget tests.
Reverting this until I find a different fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102065/new/
https://reviews.llvm.org/D102065
___
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7f78e409d028: [AMDGPU][OpenMP] Emit textual IR for
-emit-llvm -S (authored by pdhaliwal).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.
Ah, yes. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102065/new/
https://reviews.llvm.org/D102065
_
pdhaliwal added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4397
JA.getType() == types::TY_LTO_BC) {
- CmdArgs.push_back("-emit-llvm-bc");
+ // Emit textual llvm IR for AMDGPU offloading for -emit-llvm -S
+ if (Triple.isAMDGCN
JonChesterfield added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4397
JA.getType() == types::TY_LTO_BC) {
- CmdArgs.push_back("-emit-llvm-bc");
+ // Emit textual llvm IR for AMDGPU offloading for -emit-llvm -S
+ if (Triple.is
pdhaliwal created this revision.
pdhaliwal added reviewers: jdoerfert, JonChesterfield, ronlieb, gregrodgers.
Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl,
nhaehnle, jvesely, kzhuravl.
pdhaliwal requested review of this revision.
Herald added subscribers: cfe-commits,