This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdaf3cb3b8a58: [clangd][index-sever] Limit results in
repsonse (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:152
+if (HasMore)
+ log("[public] Limiting result size for Lookup request.");
LookupReply LastMessage;
kbobyrev wrote:
> nit (here and elsewhere): ma
kadircet updated this revision to Diff 344289.
kadircet marked an inline comment as done.
kadircet added a comment.
- Change logs to mention original limits.
- Add the test i forgot first time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101914/ne
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
Good point, thanks!
I wonder if this can somehow make the experience worse in _some_ specific cases
but I can't think of anything on top of my mind, so this should be all good.
kadircet created this revision.
kadircet added a reviewer: kbobyrev.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This is to prevent server from b
