[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan added a comment. In D101777#2802669 , @yaxunl wrote: > It seems this patch caused build failure: Yeah, I've pushed a fix -- I'd attached the fix to the wrong diff in the stack :( Should be good now. Repository: rG LLVM Github Monorepo CHA

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

yaxunl added a comment. It seems this patch caused build failure: FAILED: tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaDeclCXX.cpp.o /usr/bin/c++ -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MAC

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

This revision was automatically updated to reflect the committed changes. urnathan marked an inline comment as done. Closed by commit rGddda05add527: [clang][NFC] Break out BaseUsingDecl from UsingDecl (authored by urnathan). Herald added a project: clang. Repository: rG LLVM Github Monorepo C

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

davrec accepted this revision. davrec added a comment. Looks good, thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan marked 2 inline comments as done. urnathan added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3390 ConstructorUsingShadowDecl(ASTContext &C, DeclContext *DC, SourceLocation Loc, - UsingDecl *Using, NamedDecl *Target, +

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan updated this revision to Diff 347401. urnathan added a comment. Addressing Davrec's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/DeclCXX.h clang/

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

davrec accepted this revision. davrec added a comment. Sorry for the delay. Richard should probably weigh in before absolutely committing to 1. BaseUsingDecl/UsingEnumDecl/UsingDecl (as implemented here) vs. single UsingDecl (Nathan's original approach) and 2. Renaming `getUsingDecl()` to `getIn

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr)

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr)

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan updated this revision to Diff 345957. urnathan added a comment. rebased onto 3cdd05e519dd , (trying to fix patch 4's precommit failure) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://revie

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan updated this revision to Diff 345520. urnathan added a comment. unbreaking bot testing of D102241 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 Files: clang-tools-extra/clangd/FindTarget.cpp cl

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan updated this revision to Diff 345426. urnathan added a comment. I stupidly tested that on the stack, not just the first diff. This removes the reference to bits from a later patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 File

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan updated this revision to Diff 345416. urnathan added a comment. Herald added subscribers: cfe-commits, usaxena95, kadircet. Herald added a project: clang-tools-extra. Address the build failure --thanks for explaining, it wasn;t clear what else I should try and build. Grepping showed no