[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I've committed on your behalf in 54bff1522fc863329894d875d54c2fe4cd1b4f3f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101776

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101776/new/ https://reviews.llvm.org/D101776 ___ cfe-commits mailing lis

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

zahen added a comment. In D101776#2736003 , @aaron.ballman wrote: >> Once accepted I'll need someone to commit the change on my behalf. > > Thanks for mentioning this up front! What email address and name would you > like to have used for attribution on

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

zahen updated this revision to Diff 342715. zahen added a comment. Updated the macro based on Aaron's suggestion. clang-formatted the function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101776/new/ https://reviews.llvm.org/D101776 Files: clang/include/clang/Analysis/CFG.h Inde

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

aaron.ballman added a comment. > Once accepted I'll need someone to commit the change on my behalf. Thanks for mentioning this up front! What email address and name would you like to have used for attribution on the commit? Comment at: clang/include/clang/Analysis/CFG.h:1392-

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

zahen created this revision. zahen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rename LLVM's single use of CALLBACK as a template parameter to work around the Windows SDK `#define CALLBACK __stdcall` I'm sympathetic to the Michael Bol