[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, jansvoboda11 wrote: > Paul-C-Anagnostopoulos wrote: > > jansvoboda11 wrote: > > > Paul-C-Anagnost

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

This revision was automatically updated to reflect the committed changes. Closed by commit rGd40a0b8af771: [TableGen] [Clang] Clean up Options.td and add asserts. (authored by Paul-C-Anagnostopoulos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

jansvoboda11 added a comment. Thanks Paul! Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, Paul-C-Anagnostopoulos wrote: > jansvoboda11 wrote: > > Paul-C-Anagnostopoulos wrote

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos updated this revision to Diff 343100. Paul-C-Anagnostopoulos added a comment. Restored whitespace as requested by Jan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101766/new/ https://reviews.llvm.org/D101766 Files: clang/include/clang/Driver/Options.td Index

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, jansvoboda11 wrote: > Paul-C-Anagnostopoulos wrote: > > jansvoboda11 wrote: > > > W

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, Paul-C-Anagnostopoulos wrote: > jansvoboda11 wrote: > > Were you planning to refactor this to

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, jansvoboda11 wrote: > Were you planning to refactor this too? You can't use the pas

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

jansvoboda11 accepted this revision. jansvoboda11 added a comment. Nice, thank you, Paul! Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, Were you planning to refactor this to

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101766/new/ https://reviews.llvm.org/D101766

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: jansvoboda11, dblaikie, craig.topper. Herald added a subscriber: dang. Paul-C-Anagnostopoulos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This revisio