[PATCH] D101743: [clangd] Fix hover crash on broken code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf800ac830941: [clangd] Fix hover crash on broken code (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D101743: [clangd] Fix hover crash on broken code

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:2447 +// Setter variable heuristic might fail if the callexpr is broken. +struct X { int Y; void [[^setY]](float) { Y = foo(x); } };)cpp"); + hokein wrote: > IIU

[PATCH] D101743: [clangd] Fix hover crash on broken code

kadircet updated this revision to Diff 342671. kadircet added a comment. - s/x/undefined Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101743/new/ https://reviews.llvm.org/D101743 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cla

[PATCH] D101743: [clangd] Fix hover crash on broken code

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:2447 +// Setter variable heuristic might fail if the callexpr is broken. +struct X { int Y; void [[^

[PATCH] D101743: [clangd] Fix hover crash on broken code

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monor