[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

dblaikie added a comment. In D101735#2749716 , @aheejin wrote: > @dblaikie I can remove this one. This is not an important test anyway. But > where are we supposed to test the arguments clang driver invokes the backend > LLVM compilation with? This was

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

aheejin added a comment. @dblaikie I can remove this one. This is not an important test anyway. But where are we supposed to test the arguments clang driver invokes the backend LLVM compilation with? This was mainly to test if `-exception-model=wasm` reaches the backend compilation. Repositor

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

dblaikie added a comment. FWIW - please avoid end-to-end tests where possible (writing separate source to LLVM IR (in clang) and LLVM IR to assembly (in LLVM) tests). (recent discussions on the wasm simd instructions touched on this issue too) Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c1406f24d8b: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101735/new/ https:/

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. This is hopefully less controversial because the test already exists and this is just re-enabling it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was temporarily disabled