[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

2021-05-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c2afd5899df: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

2021-05-11 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101667/new/ https://reviews.llvm.org/D101667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

2021-05-10 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Ping! Happy to weaken the commit message to "likely NFC" in case there's some way that we get back here after a fatal error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101667/new/ https://reviews.llvm.org/D101667 __

[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

2021-05-03 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Just marked this as a "parent" of https://reviews.llvm.org/D101670 and https://reviews.llvm.org/D101672 since the patches conflict, but if for some reason this one is controversial I *can* rebase them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

2021-04-30 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: jansvoboda11, Bigcheese, rsmith. dexonsmith requested review of this revision. Herald added a project: clang. 5cca622310c10fdf6f921b6cce26f91d9f14c762 (https://revi