This revision was automatically updated to reflect the committed changes.
Closed by commit rGc58a6a6fb411: [HIP] Fix device lib selection (authored by
yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101654/new/
yaxunl updated this revision to Diff 342156.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Herald added a subscriber: dexonsmith.
revise test by Fangrui's comment. Also fix test failure
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101654/new/
https://reviews.llvm.org
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/test/Driver/hip-device-libs.hip:165
+// FAST: "-mlink-builtin-bitcode" "{{.*}}oclc_daz_opt_off.bc"
+// FAST-SAME: "-mlink-builtin-bitcode" "{{.*}}oclc_unsafe_math_on.bc"
+// FAST-SAME: "-mlin
MaskRay added inline comments.
Comment at: clang/test/Driver/hip-device-libs.hip:165
+// FAST: "-mlink-builtin-bitcode" "{{.*}}oclc_daz_opt_off.bc"
+// FAST-SAME: "-mlink-builtin-bitcode" "{{.*}}oclc_unsafe_math_on.bc"
+// FAST-SAME: "-mlink-builtin-bitcode" "{{.*}}oclc_finite_on
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/test/Driver/hip-device-libs.hip:117
+// Test -fast-math
+// RUN: %clang -### -target x86_64-linux-gnu \
+// RUN: --cuda-gpu-arch=gfx900 \
MaskRay wrote:
> You can pack more
MaskRay added inline comments.
Comment at: clang/test/Driver/hip-device-libs.hip:117
+// Test -fast-math
+// RUN: %clang -### -target x86_64-linux-gnu \
+// RUN: --cuda-gpu-arch=gfx900 \
You can pack more arguments on one line.
Fewer line wraps actually make a
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added a subscriber: dang.
yaxunl requested review of this revision.
Choose optimized device lib bitcode by fp options
for performance.
https://reviews.llvm.org/D101654
Files:
clang/include/clang/Driver/Options.td
clang/lib/C
