[PATCH] D101635: [analyzer] Fix assertion in SVals.h

ASDenysPetrov added a comment. Herald added a subscriber: manas. @steakhal, @NoQ Thanks for your replies. I've made a patch according your suggestions D103319 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101635

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

NoQ added a comment. In D101635#2731210 , @steakhal wrote: > Does anyone have an idea how to prevent such a silly mistake from happening > again? Maybe use more optionals? I.e., `castRegion` may fail, so let's change it to return `Optional` where the p

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

steakhal added a comment. I don't know how did we miss this. I run your patch on several projects and it seemed good. Does anyone have an idea how to prevent such a silly mistake from happening again? I was thinking of coverage data, but that wouldn't be enough for this example.

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGa27af1d8166c: [analyzer] Fix assertion in SVals.h (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. @vabridgers Thank you for a good catch! The fix looks fairly reasonable for me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1016

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

vabridgers created this revision. vabridgers added reviewers: ASDenysPetrov, NoQ, steakhal, martong, vsavchenko. Herald added subscribers: dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this rev