[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

2021-04-30 Thread Scott Linder via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcab19d84ce85: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101542/new/ https:

[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

2021-04-29 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101542/new/ https://reviews.llvm.org/D101542

[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

2021-04-29 Thread Scott Linder via Phabricator via cfe-commits
scott.linder added reviewers: MaskRay, dineshkb-amd, aykevl. scott.linder added a comment. I'm not sure who else to add, please feel free to update the reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101542/new/ https://reviews.llvm.org/D10

[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

2021-04-29 Thread Scott Linder via Phabricator via cfe-commits
scott.linder created this revision. scott.linder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduce an extra scope (another static function) to replace calls to `unique_ptr::reset` with implicit destructors via RAII. Repository: