[PATCH] D101515: clang-format: [JS] handle "off" in imports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2780cd744ea: clang-format: [JS] handle "off" in imports (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst updated this revision to Diff 341849. mprobst added a comment. - review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 Files: clang/lib/Format/SortJavaScriptImports.cpp clang/unittes

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir accepted this revision. krasimir added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:257 +// references per group. +auto *Start = References.begin(); +SmallVector ReferencesSorted; please fix lint warning on line 257

[PATCH] D101515: clang-format: [JS] handle "off" in imports

h-joo accepted this revision. h-joo added a comment. This revision is now accepted and ready to land. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 __

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst marked an inline comment as done. mprobst added a comment. added test for merging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 ___ cfe-commits mailin

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst updated this revision to Diff 341815. mprobst added a comment. - test for avoiding merges Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 Files: clang/lib/Format/SortJavaScriptImports.cpp clan

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst updated this revision to Diff 341814. mprobst marked 4 inline comments as done. mprobst added a comment. - review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 Files: clang/lib/Format

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst marked 9 inline comments as done. mprobst added a comment. PTAL, addressed review comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:191 +!(FirstNonImportLine->First->is(tok::comment) && + FirstNonImportLine->First->TokenText.trim() == "//

[PATCH] D101515: clang-format: [JS] handle "off" in imports

h-joo requested changes to this revision. h-joo added a comment. This revision now requires changes to proceed. In D101515#2726889 , @krasimir wrote: > @h-joo , seems we had a comment race :D cheers! :D Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir added a comment. @h-joo , seems we had a comment race :D cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 ___ cfe-commits mailing list cfe-commi

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:158 std::string ReferencesText; -bool SymbolsInOrder = true; -for (unsigned i = 0, e = Indices.size(); i != e; ++i) { - JsModuleReference Reference = References[Indices[i]]; -

[PATCH] D101515: clang-format: [JS] handle "off" in imports

h-joo added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:252 + SmallVector + sortModuleReferences(SmallVector &References) { +// Sort module references. `References` seem read-only. Can you make it `const Smallvector &`? ===

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst created this revision. mprobst added reviewers: krasimir, h-joo. mprobst requested review of this revision. Herald added a project: clang. Previously, the JavaScript import sorter would ignore `// clang-format off` and `on` comments. This change fixes that. It tracks whether formatting is