[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay added a comment. In D101194#2721682 , @phosek wrote: > In D101194#2721643 , @MaskRay wrote: > >> multiarch is not consistent within GCC, either (also note that not all GCC >> installations are configured

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2721643 , @MaskRay wrote: > multiarch is not consistent within GCC, either (also note that not all GCC > installations are configured with multiarch. `--print-multiarch` prints an > empty line). > I have tried various

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay added a comment. In D101194#2721597 , @phosek wrote: > In D101194#2721390 , @MaskRay wrote: > >> I thought this was NFC:( >> >> Yeah, personally I think the previous behavior >> (`lib/clang/13.0.0/lib/x86

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2721390 , @MaskRay wrote: > I thought this was NFC:( > > Yeah, personally I think the previous behavior > (`lib/clang/13.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.asan.a`) is > slightly better than the new > `lib/c

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay added a comment. I thought this was NFC:( Yeah, personally I think the previous behavior (`lib/clang/13.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.asan.a`) is slightly better than the new `lib/clang/13.0.0/lib/x86_64-linux-gnu/libclang_rt.asan.a`. multiarch paths are suitable for GCC

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay added a comment. FWIW I have played `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on` I see `lib/clang/13.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.*`. The directory name is `x86_64-unknown-linux-gnu`, which actually looks good to me. We don't necessarily copy the GCC x86_64-linux-gnu multiar

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

bjope added a comment. In D101194#2720787 , @phosek wrote: > In D101194#2720761 , @bjope wrote: > >> Or maybe the problem is that we use `-DLLVM_BUILTIN_TARGETS=default`? > > The use of `default` is the issue, the

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2720761 , @bjope wrote: > Got some problems with my builds after this commit. > > My cmake commands looks like this (well, this is after having tried to fix > the problem by replacing `x86_64-unknown-linux-gnu` by `x86_

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

bjope added a comment. Got some problems with my builds after this commit. My cmake commands looks like this (well, this is after having tried to fix the problem by replacing `x86_64-unknown-linux-gnu` by `x86_64-linux-gnu` as I figured that might be needed after looking at the changes in this

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4537c3f51bc: [Driver] Push multiarch path setup to individual drivers (authored by phosek). Herald added subscribers: libcxx-commits, s.egerton, sim

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D101194#2714991 , @phosek wrote: > In D101194#2714206 , @MaskRay wrote: > >>> Different platforms use di

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2714206 , @MaskRay wrote: >> Different platforms use different rules for multiarch triples so it's >> difficult to provide a single method for all platforms. > > Guess this is a Linux/Hurd/Fuchsia specific thing. I don'

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay added a comment. > Different platforms use different rules for multiarch triples so it's > difficult to provide a single method for all platforms. Guess this is a Linux/Hurd/Fuchsia specific thing. I don't know much about the runtime build but I hope the hierarchy is not set in stone.

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek created this revision. phosek added a reviewer: MaskRay. Herald added subscribers: jgravelle-google, sbc100, dschuff. phosek requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Different platforms use different rules for multiarc