[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield updated this revision to Diff 339806. JonChesterfield added a comment. This revision is now accepted and ready to land. - factor out last arg wins Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101117/new/ https://reviews.llvm.org/D1

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield abandoned this revision. JonChesterfield added a comment. Abandoning this. Unacceptably ugly, will revise D101077 in a slightly different direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

yaxunl added a comment. In D101117#2710368 , @JonChesterfield wrote: > I'm not very pleased with this. There's too much state to move around when > representing the failure and the control flow is probably harder to read than > it was in the original.

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. nice. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101117/new/ https://reviews.llvm.org/D101117 __

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield added a comment. I'm not very pleased with this. There's too much state to move around when representing the failure and the control flow is probably harder to read than it was in the original. May take another pass at it. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield created this revision. JonChesterfield added a reviewer: yaxunl. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. [c