[PATCH] D101095: [clang][amdgpu] Use implicit code object version

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc88d927e30d: [clang][amdgpu] Use implicit code object version (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101095/new/ http

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

JonChesterfield added a comment. In D101095#2713652 , @yaxunl wrote: > In general we think we should move toward the direction of clang being > agnostic about code object version and let backend decide which code object > version to use This sounds the

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. I talked with Tony about the code object version arguments of clang. In general we think we should move toward the direction of clang being agnostic about code object version and let backend d

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

yaxunl added a comment. LGTM. However, I would like to hear Tony's opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101095/new/ https://reviews.llvm.org/D101095 ___ cfe-commits mailing list cfe-com

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

JonChesterfield updated this revision to Diff 339824. JonChesterfield added a comment. - simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101095/new/ https://reviews.llvm.org/D101095 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

JonChesterfield updated this revision to Diff 339820. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101095/new/ https://reviews.llvm.org/D101095 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/D

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

JonChesterfield added a comment. Diff created relative to D101077 , not relative to main. Iiuc that will work out fine if the NFC lands first. Comment at: clang/test/Driver/hip-code-object-version.hip:55 // RUN: %s 2>&1 | FileCheck -check-p

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

JonChesterfield created this revision. JonChesterfield added reviewers: yaxunl, t-tye, kzhuravl, ronlieb, b-sumner, pdhaliwal. Herald added subscribers: pengfei, tpr, dstuttard. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a