[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0efc0075131: [OpenCL] Introduce new method for validating OpenCL target (authored by azabaznov). Changed prior to commit: https://reviews.llvm.org/D101087?vs=341119&id=341170#toc Repository: rG LLVM

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia accepted this revision. Anastasia added a comment. Cool! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101087/new/ https://reviews.llvm.org/D101087 ___ cfe-commits mailing list cfe-comm

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

azabaznov updated this revision to Diff 341119. azabaznov added a comment. Add test for C++ for OpenCL diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101087/new/ https://reviews.llvm.org/D101087 Files: clang/include/clang/Basic/Diagno

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. I have made a minor suggestion to testing that could be addressed in the final commit. Comment at: clang/test/Misc/nvptx.unsupported_core.cl:1 +// RUN:

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:179 + static bool isOpenCLOptionCoreIn(const LangOptions &LO, Args &&... args) { +return OpenCLOptionInfo(std::forward(args)...).isCoreIn(LO); + } Anastasia wrote: > Do y

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

azabaznov updated this revision to Diff 340053. azabaznov added a comment. Use `LangOptions::getOpenCLVersionTuple()` to provide diagnostics of OpenCL version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101087/new/ https://reviews.llvm.org/D1010

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:365 +def warn_opencl_unsupported_core_feature : Warning< + "%0 is a core feature in OpenCL C %1 but not supported on this target">, + InGroup, DefaultIgnore; I would

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

azabaznov updated this revision to Diff 339983. azabaznov added a comment. Herald added a reviewer: aaron.ballman. Addressed comments, did some more refactoring. Is it OK to have "2.0" diagnostics for C++ for OpenCL? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia added a comment. Just a few nitpicks otherwise it looks great! Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:364 + +def warn_opencl_not_supported_core_feature : Warning< + "%0 is a core feature in this OpenCL version but not supported on this target

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, jfb, yaxunl, jvesely. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Language options are not available when a targe