[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cdb9873b210: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101077/new/ https://reviews.llvm.org/D101077 __

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1576 -unsigned tools::getOrCheckAMDGPUCodeObjectVersion( -const Driver &D, const llvm::opt::ArgList &Args, bool Diagnose) { +static llvm::opt::Arg * +getAMDGPUCodeObjectArgument(co

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield updated this revision to Diff 339810. JonChesterfield added a comment. - whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101077/new/ https://reviews.llvm.org/D101077 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield updated this revision to Diff 339807. JonChesterfield added a comment. - factor out last arg wins Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101077/new/ https://reviews.llvm.org/D101077 Files: clang/lib/Driver/ToolChains/AMDGP

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1626 } else { - auto Remnant = - StringRef(CodeObjArg->getValue()).getAsInteger(0, CodeObjVer); - if (Diagnose && - (Remnant || CodeObjVer < MinCodeObjVe

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1626 } else { - auto Remnant = - StringRef(CodeObjArg->getValue()).getAsInteger(0, CodeObjVer); - if (Diagnose && - (Remnant || CodeObjVer < MinCodeObjVe

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1592-1598 + if (auto *CodeObjArg = + Args.getLastArg(options::OPT_mcode_object_v3_legacy, + options::OPT_mno_code_object_v3_legacy, + o

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1597 + +if (CodeObjArg->getOption().getID() == +options::OPT_mcode_object_version_EQ) { This would probably be more useful if it diagnosed an invalid argumen

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield created this revision. JonChesterfield added reviewers: yaxunl, t-tye, kzhuravl, ronlieb, b-sumner, pdhaliwal. Herald added subscribers: kerbowa, tpr, dstuttard, nhaehnle, jvesely. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, wdng. Heral