[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

2022-07-25 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 447358. Ericson2314 added a comment. Rebase, make caller responsible for making paths absolute This avoids module resolution issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://review

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

2022-07-25 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 added a comment. @sebastian-ne Thanks yes I was worried that might happen. I think I will just move the `extend_path` to the caller then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070 _

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

2022-07-25 Thread Sebastian Neubauer via Phabricator via cfe-commits
sebastian-ne added a comment. In D101070#3675462 , @sebastian-ne wrote: > Hi, not sure if you saw D130256 , but I > needed to extend CMAKE_MODULE_PATH, otherwise the ExtendPath module was not > found when running LLVMI

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

2022-07-25 Thread Sebastian Neubauer via Phabricator via cfe-commits
sebastian-ne added a comment. Hi, not sure if you saw D130256 , but I needed to extend CMAKE_MODULE_PATH, otherwise the ExtendPath module was not found when running LLVMInstallSymlink.cmake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

2022-07-23 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 447108. Ericson2314 added a comment. Rebase to retrigger CI I think it tried to cherry-pick an already-landed patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D1010